Repository navigation
Fix VM signal chaining and build eos-vm from a submodule - #757
Open
huangminghuang wants to merge 4 commits into
Open
huangminghuang wants to merge 4 commits into
huangminghuang wants to merge 4 commits into
Conversation
Change-Id: I5c03bce57647708db0d9fb473b310f4099266c56
heifner
previously approved these changes
Nov 10, 2026
heifner
reviewed
Nov 10, 2026
heifner
left a comment
Contributor
There was a problem hiding this comment.
wire-sys-vm's chain_previous_signal_handler has the second of these defects: it tests SA_SIGINFO first and calls sa_sigaction without checking for SIG_IGN / SIG_DFL. It is what decodes the predecessor on a node without OC, so it is worth the same fix there.
Use sig consistently for handler arguments. Register the runtime-independent signal suite once, exclude it from per-runtime discovery, and keep it in the CI unit-test filter. Change-Id: I4cebf3ce64be3ec8a5a950bd3f81bb894b640236
Contributor
Author
|
The non-OC sentinel issue is reproduced and fixed in Wire-Network/eos-vm#16. The new tests fail against the original header and pass with GCC 14 and Clang sanitizers; the complete VM unit suite passes 269 cases. A registry port revision will be needed after that fix merges to bring it into Sysio. |
heifner
reviewed
Nov 10, 2026
Drop the redundant trailing anchor from the runtime-independent unit-test filter. The non-VERBATIM coverage command otherwise produces invalid Ninja syntax and an unterminated Make shell quote. Validate the actual coverage command block with Ninja and Unix Makefiles. Change-Id: I631ca2914d7c49c0b40615c20dbe5709ecca532c
heifner
previously approved these changes
Nov 10, 2026
Change-Id: I6b3db83c4b7b165296728dcfc72b7c78176ba255
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signal chaining can call a legacy handler through the wrong ABI in the OC executor, or treat
SIG_IGN/SIG_DFLas callback addresses whenSA_SIGINFOis set. Preserve each predecessor's calling convention and consume the merged non-OC fix directly from eos-vm.sigactionstructures. Keep the executor's existing default-fault fallback.libraries/sys-vmas a submodule pinned to2c8d4b283b500f56241450bdc60a594455a972d9, the merged eos-vm #16. Remove thewire-sys-vmvcpkg dependency, version override, registry entry, and package lookups. Softfloat remains a vcpkg dependency; no VM registry revision is needed.Validation:
libraries/sys-vm/include. Of the 42 VM headers, onlysignals.hppdiffers from the previous package.