Repository navigation
Fix reentrant desyndication custody attestations (WIRE-441) - #756
Merged
Merged
Conversation
Change-Id: I3c9ae88cbc907104bc27cbcceb042bc43db62b48
This was referenced Nov 9, 2026
huangminghuang
marked this pull request as ready for review
November 9, 2026 22:30
heifner
previously approved these changes
Nov 9, 2026
huangminghuang
marked this pull request as draft
November 10, 2026 16:34
Resolve the generated sysio.synd WASM conflict by rebuilding the combined source with current CDT. Preserve upstream strict action decoding and cover trailing bytes on the internal continuation. Change-Id: Ib835d2d8939a80e19c541e657850a761308bfa79
Change-Id: I4263ec3e02cb3c789b6fd1cacc330f804e7bed84
heifner
approved these changes
Nov 10, 2026
huangminghuang
marked this pull request as ready for review
November 11, 2026 00:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Desyndication previously encoded outstanding supply before its queued transfer and burn executed. A holder notification could re-enter, making the later outer attestation overstate outstanding shadow and falsely freeze a fully backed outpost. The final self-inline action reads the recorded request and live supply plus parked yield, then queues the attestation without an intervening external callback.
The one-shot unprivileged callback completes within the default inline depth of four. The combined contract preserves upstream return-envelope epoch tracking, automatic balance-row creation and strict action-data decoding.
Validation
--sys-vm-jit: 243 cases and 21,068 assertions passed, including live nested/outer totals, fees and parked yield, rollback and emission authorization.Companion PRs
master. Merge after Sysio. No current consumer requires a new npm release.next. Part of the same coordinated merge batch.next.master. Include the selected fix branch in coordinated validation.