Repository navigation
Require Payer Authorization on Msig Propose - #751
Merged
Merged
Conversation
propose already bills the proposal's RAM to the proposer. It now also requires {proposer, sysio.payer} as the first authorization, so the proposer pays its CPU and NET too, including the NET of the proposed transaction.
clio multisig propose, propose_trx, exec and cancel now keep the signer's own permission when -P is given without -p.
Change-Id: I4adac9eab1645a2665cc960e920214b609f2ead0
huangminghuang
approved these changes
Nov 7, 2026
huangminghuang
left a comment
huangminghuang
left a comment
Contributor
There was a problem hiding this comment.
Reviewed all 11 changed files and relevant authorization/resource-billing code. No actionable findings.
Validation passed: 28 clio cases, 5 WASM probes, and syntax checks for clio and multisig tests. Full contract tests remain unverified because the available build has stale generated protobuf headers. WASM probes used mocked host functions.
heifner
marked this pull request as ready for review
November 9, 2026 23:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sysio.msig::proposealready bills the proposal's RAM to the proposer. It now also requires{proposer, sysio.payer}as the first authorization, so the proposer pays the CPU and NET ofproposetoo, including the NET of the proposed transaction, which is the action's data.approve,unapprove,cancel,execandinvalidateare unchanged. No ABI change.clio:
multisig propose,propose_trx,execandcancelsent only the payer marker when-Pwas given without-p. They now send{payer, sysio.payer}, {signer, active}, soclio multisig propose_trx <name> <requested> <trx> <proposer> -P <proposer>works.Follow-ups outside this repo:
buildProposeAction, and Wire-Network/wire-hub-webapp#240 updates the Hub msig journeys and takes that sdk-core release. @joshglogaumax_transaction_net_usageof NET to its proposer, so governance proposers need a ROA policy that covers it.