Repository navigation
Fix clio wallet CLI option storage lifetime - #371
Merged
Merged
Conversation
heifner
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The ASAN job in PR #369 failed during the regular parallel test phase before the sharded NP/LR tests ran:
clioregistered CLI11 options backed by strings declared inside short wallet subcommand setup blocks. CLI11 keeps references to those option targets and invokes parse/callback logic after those blocks have exited, so ASAN correctly reports use-after-scope whenwallet importwrites towallet_key_str.Fix
Hoist the wallet subcommand option storage to the lifetime of the wallet command setup in
main, covering:wallet importwallet remove_keywallet remove_namewallet create_keywallet set_key_nameThis keeps the existing CLI behavior while ensuring CLI11 option targets outlive parse and callback execution.
Verification
build/clio-asan-fix.cliosuccessfully: