Repository navigation
Conversation
With CPACK_DEB_COMPONENT_INSTALL enabled, install() rules without a COMPONENT go to "Unspecified" which is excluded from both the base and dev .deb packages. This adds COMPONENT to all 21 install() rules that were missing it: - trace_api_util binary -> base (was silently excluded from .deb) - Licenses directory -> base and dev - Headers, static libraries, and cmake configs -> dev (libfc, libfc-lite, sysio_chain, builtins, sysio_testing, wasm-jit, vcpkg includes/libs, sysio cmake configs)
huangminghuang
requested changes
May 6, 2026
huangminghuang
left a comment
huangminghuang
left a comment
Contributor
There was a problem hiding this comment.
COMPONENT dev EXCLUDE_FROM_ALL now belongs only to PUBLIC_HEADER, because install(TARGETS) options after artifact kinds apply only to current artifact group. ARCHIVE stays Unspecified, so default static build still omits libsysio_testing.a from sysio-dev. Fix: put COMPONENT dev EXCLUDE_FROM_ALL in each artifact group, or before artifact-kind groups as generic target options where valid.
Contributor
Author
|
Replaced by #511 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With CPACK_DEB_COMPONENT_INSTALL enabled, install() rules without a COMPONENT go to "Unspecified" which is excluded from both the
baseanddev.deb packages. This adds COMPONENT to all 21 install() rules that were missing it:trace_api_utilbinary ->base(was silently excluded from .deb)baseanddevdev(libfc, libfc-lite, sysio_chain, builtins, sysio_testing, wasm-jit, vcpkg includes/libs, sysio cmake configs)