Repository navigation
Drop Context-Free Fields From Traces and Chain Parameters - #150
Merged
Merged
Conversation
Context-free actions are gone from wire-sysio, so action traces no longer carry `context_free` and sdk-core's `TransactionTrace` drops the field. `SysioContractTypes.ts` is regenerated from wire-sysio master: the `blockchain_parameters` type of `sysio.bios` and `sysio.system` loses `context_free_discount_net_usage_num` and `context_free_discount_net_usage_den`. Transactions keep `context_free_actions` and `context_free_data`, which must be empty, so client serialization is unchanged.
huangminghuang
approved these changes
Nov 10, 2026
huangminghuang
left a comment
huangminghuang
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the current diff and relevant SDK context using Open Code Review. No actionable findings.
The trace-field removal matches wire-sysio#754, and both generated blockchain-parameter interfaces match the producer ABIs at wire-sysio 236436f633.
Validation on an isolated snapshot of 669acb2: shared and sdk-core build passed; 7 focused test suites passed (67 tests).
heifner
marked this pull request as ready for review
November 10, 2026 17:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to Wire-Network/wire-sysio#754, which removed context-free actions.
TransactionTrace(the trace type behindget_transactiontraces) dropscontext_free.SysioContractTypes.tsis regenerated from wire-sysio master (236436f633): theblockchain_parameterstype ofsysio.biosandsysio.systemlosescontext_free_discount_net_usage_numandcontext_free_discount_net_usage_den. Nothing else in the file changed; the msigproposechange from wire-sysio#751 changes authorization only, not the ABI.context_free_actionsandcontext_free_data, which must be empty, so client serialization is unchanged.#148 also regenerates
SysioContractTypes.ts, from wire-sysio#759's branch. Whichever lands second regenerates the file again.Pairs with Wire-Network/wire-tools-ts#182, which drops the two parameters from the cluster genesis. Neither PR depends on the other.