Skip to content

Fail loudly for CRAFTING/CREATIVE CraftContainer types #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
windcolor-dev merged 5 commits into from
Oct 15, 2026
Merged

Fail loudly for CRAFTING/CREATIVE CraftContainer types #201

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cb51262
Fix CraftContainer silent fall-through for CRAFTING/CREATIVE
cursoragent Oct 13, 2026
d1cf28f
Update CraftContainer.java
kalibrieren Oct 14, 2026
371409c
Delete WindSpigot-Server/src/test/java/com/windpvp/windspigot/invento…
kalibrieren Oct 14, 2026
02cb9a6
Fix CraftContainer silent fall-through for CRAFTING/CREATIVE
cursoragent Oct 14, 2026
a886b9e
Merge pull request #53 from kalibrieren/fix/craftcontainer-inventory-…
xii69 Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions WindSpigot-Server/src/main/java/org/bukkit/craftbukkit/inventory/CraftContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,9 @@ public boolean c(EntityHuman entityhuman) {

public static String getNotchInventoryType(InventoryType type) {
switch (type) {
case CREATIVE:
case CRAFTING:
throw new IllegalArgumentException("Can't open a " + type + " inventory!");
case WORKBENCH:
return "minecraft:crafting_table";
case FURNACE:
Expand All @@ -119,7 +122,8 @@ public static String getNotchInventoryType(InventoryType type) {
private void setupSlots(IInventory top, IInventory bottom) {
switch (cachedType) {
case CREATIVE:
break; // TODO: This should be an error?
case CRAFTING:
throw new IllegalArgumentException("Can't open a " + cachedType + " inventory!");
case PLAYER:
case CHEST:
setupChest(top, bottom);
Expand All @@ -130,7 +134,6 @@ private void setupSlots(IInventory top, IInventory bottom) {
case FURNACE:
setupFurnace(top, bottom);
break;
case CRAFTING: // TODO: This should be an error?
case WORKBENCH:
setupWorkbench(top, bottom);
break;
Expand Down