Repository navigation
Check for lava once per tick - #196
Merged
windcolor-dev merged 6 commits intoOct 22, 2026
Merged
Conversation
Inline Paper combust-once + combuster block rules in burnFromLava. Co-authored-by: xii69 <[email protected]>
cursor
Bot
force-pushed
the
fix/lava-combust-event
branch
from
October 14, 2026 21:17
e233240 to
a10530b
Compare
windcolor-dev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Standing in lava could spam
EntityCombustByBlockEvent, and the “block that set you on fire” was always null. That’s noisy for plugins and breaks the event contract.What this changes
Only fire the combust event on first ignition for living entities (
fireTicks <= 0). TracklastLavaContactand pass that real lava block into the event. Already-burning entities just refresh fire without re-firing the event.Why this is needed
Plugins listening to combust-by-block expect a real block and a reasonable fire rate. Spam + null is both a perf annoyance and an API bug.
Testing
LavaCombustTest4/4; full server suite green; package OK.