Skip to content

✅ test(desktop): retry a dropped fold key press in US6.1 - #3

Merged
Wald764 merged 1 commit into
mainfrom
fix/us61-fold-retry
Nov 4, 2026
Merged

Wald764 merged 1 commit into
mainfrom
fix/us61-fold-retry

Conversation

@Wald764

@Wald764 Wald764 commented Nov 2, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes the US6.1-keyboard-journey flake that turned PR #2 red (run 41539564163, ubuntu-24.04 / 1.142.0 / authoring). After ArrowRight, the root row stayed collapsed for 15 s.

The native tree drops a Left or Right key press while a refresh is in flight. foldAndUnfoldRoot now retries the key press within a bounded window:

  • It re-presses only while the row still shows the pending state. It never presses Right on an expanded row, which would move focus to the first child.
  • It asserts that focus stays on the root row.
  • The overall 15 s timeout is unchanged, so a real regression still fails.

Verification

  • Ran locally: tsc --noEmit, eslint and prettier --check on the file all pass.
  • Not run locally: the e2e test itself, which needs the VS Code download. The CI stability gate repeats this changed spec across the matrix.

🤖 Generated with Claude Code

The native tree drops a Left or Right pressed while a refresh is in flight (run 41539564163). Re-press only while the root row still shows the pending state, and keep focus on the root row.
@Wald764
Wald764 merged commit e0c53a9 into main Nov 4, 2026
36 checks passed
@Wald764
Wald764 deleted the fix/us61-fold-retry branch November 4, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant