Repository navigation
🐛 fix(sidebar): skip tree refreshes that change nothing visible - #1
Merged
Merged
Conversation
Compare the rendered rows before firing a whole-view refresh, keep the tree's own fold state out of that comparison, and do not mark Pending for a selection that exactly repeats the accepted one while nothing else is queued. US6.1 now folds and unfolds after a selection. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Write each session's trace into its Playwright test output dir and preserve failing outputs only, instead of deleting every trace before upload. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onDidChangeTreeData. Kept rows adopt the new node/component and authority. The tree's fold state is excluded from the comparison, so a user fold is not undone by the next no-op publication.preserveOutput: 'failures-only'. Failing tests keep their traces in the uploaded evidence; the CI step that deleted every trace is removed.Tests
tests/vscode/sidebar-refresh.test.ts(fails on the previous code): no-op publications, fold persistence, structural changes, Pending on first / A,B,A / primary-change selections, silent repeats.accessibility.spec.tsUS6.1 now folds and unfolds after a selection and requires exact focus return after Escape. This change also exercises the stability gate (5 repeats, strict).🤖 Generated with Claude Code