Repository navigation
rabbit_plot_cov: name the missing --params entry instead of raising TypeError - #227
Conversation
…ypeError args.params is a list, so boolean-mask indexing it on the error path raised TypeError and hid which parameter was not in the fit result. Co-Authored-By: Claude Opus 5.5 <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Issues Found
No issues found.
Summary
Total issues: 0 critical, 0 important, 0 minor.
Overall Verdict
Status: Patch is correct
Explanation: The fix correctly converts the argparse list args.params to a numpy array before boolean-mask indexing, so the error path now raises the intended RuntimeError naming the missing parameter instead of a TypeError. Semantics for valid calls are unchanged (np.isin converts lists identically), and subsequent uses of args.params (e.g., the indices loop) still operate on the original list as before.
Review details
- Model:
cern/Kimi-K3-FLATIRON
Review metrics: 3 turns · 4 tool calls · 55s
- Tokens:
14.1Kinput ·9.7Kcached (69%) ·2.8Koutput
|
CI status — workflow |
|
CI green ✅ — 19/19 jobs successful on 382faed (run 42661717175). Slowest: all-unit-tests 1h21m. Ready for review. |
args.paramsis a list. On the error path for a parameter missing from the fit result,args.params[~isin]raisedTypeError, which hid the missing name. The list is now converted withnp.asarrayfirst, so theRuntimeErrornames the parameter. Valid calls are unchanged.🤖 Generated with Claude Code