feat: media session API and siemap fixes - #164
Conversation
|
Warning Review limit reached
Next review available in: 4 minutes Limit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (21)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
1 issue found across 20 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/www/registry/default/blocks/audio-player/player.tsx">
<violation number="1" location="apps/www/registry/default/blocks/audio-player/player.tsx:90">
P2: When an app renders multiple `AudioPlayer`s, this mounts a controller for each singleton `navigator.mediaSession`. An empty or secondary player can clear or overwrite the active player's controls and metadata; add shared ownership so only the focused player synchronizes the global session.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| source={source} | ||
| sourceKey={sourceKey} | ||
| > | ||
| <AudioMediaSessionController /> |
There was a problem hiding this comment.
P2: When an app renders multiple AudioPlayers, this mounts a controller for each singleton navigator.mediaSession. An empty or secondary player can clear or overwrite the active player's controls and metadata; add shared ownership so only the focused player synchronizes the global session.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/www/registry/default/blocks/audio-player/player.tsx, line 90:
<comment>When an app renders multiple `AudioPlayer`s, this mounts a controller for each singleton `navigator.mediaSession`. An empty or secondary player can clear or overwrite the active player's controls and metadata; add shared ownership so only the focused player synchronizes the global session.</comment>
<file context>
@@ -86,6 +87,7 @@ export const AudioPlayer = React.forwardRef<HTMLDivElement, AudioPlayerProps>(
source={source}
sourceKey={sourceKey}
>
+ <AudioMediaSessionController />
<RootContainer
aria-label="Audio player"
</file context>
2d47543 to
afc40a1
Compare
Summary by CodeRabbit