feat: hide admin-only sidebar links for non-signer wallets - #561
Open
BABAT-CODE wants to merge 1 commit into
Open
feat: hide admin-only sidebar links for non-signer wallets#561BABAT-CODE wants to merge 1 commit into
BABAT-CODE wants to merge 1 commit into
Conversation
Admin-only nav items (Treasury, Signers, Settings) are now hidden for any wallet that is not a registered signer in the treasury contract. Changes: - Sidebar.tsx: mark Treasury, Signers, and Settings links as adminOnly. Filter visibleLinks using the treasury signer list fetched by useSigners(). Fail-closed while the signer list is loading to prevent a flash of privileged links. Accept a connectedAddress prop. - DashboardLayout.tsx: add useWalletAddress() and pass the resolved address to Sidebar as connectedAddress. - hooks/useWalletAddress.ts: new hook that polls Freighter for the connected public key every 5 s (returns null when not connected). - Sidebar.test.tsx: 7 tests covering non-admin wallet hides links, no wallet hides links, signer sees all links, loading state fail-closed, and case-insensitive address matching. Closes WHEELBACK#3
|
@BABAT-CODE Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Admin-only nav items (Treasury, Signers, Settings) are now hidden for any wallet that is not a registered signer in the treasury contract.
Changes:
Pull Request
Summary
Checklist
abis/andCOMEBACKHERE-contracts/)Notes
make check-abi-snapshots.closes #463