feat: add confirmation prompt to network switch with unsaved state - #558
Open
BABAT-CODE wants to merge 1 commit into
Open
feat: add confirmation prompt to network switch with unsaved state#558BABAT-CODE wants to merge 1 commit into
BABAT-CODE wants to merge 1 commit into
Conversation
Show a confirmation dialog when the user attempts to switch networks while one or more dashboard forms have unsaved state registered via window.__networkSelectorDirtyForms. This prevents accidental context loss (e.g. a half-filled settlement proposal) when switching away from mainnet mid-session. - Update NetworkSelector.tsx to intercept network changes and show an accessible dialog (role=dialog, aria-modal, labelled/described by IDs) when dirty form state is detected. - Add confirmation dialog styles to NetworkSelector.css. - Add NetworkSelector.test.tsx with 7 tests covering: clean switch, dirty-state prompt, confirm action, cancel action, and mainnet warning. Closes WHEELBACK#1
|
@BABAT-CODE Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show a confirmation dialog when the user attempts to switch networks while one or more dashboard forms have unsaved state registered via window.__networkSelectorDirtyForms. This prevents accidental context loss (e.g. a half-filled settlement proposal) when switching away from mainnet mid-session.
Pull Request
Summary
Checklist
abis/andCOMEBACKHERE-contracts/)Notes
make check-abi-snapshots.closes feat: add NetworkSelector confirmation prompt when switching from mainnet to testnet #455