fix: add distinct OnHold visual state to StatusBadge - #557
Open
LockedTerminal wants to merge 1 commit into
Open
Conversation
Closes WHEELBACK#258 - Add OnHold to InvoiceStatus enum in comebackhere-frontend types - Add badge--on-hold CSS class to App.css (visually distinct from badge--pending via a solid amber border, same warm background tone) - Add statusLabels map so OnHold renders as 'On Hold' (human-readable) - Update aria-label to use the human-readable label - Add StatusBadge.test.tsx covering all 7 status variants with explicit assertions for the new OnHold class, label text, aria-label, and that OnHold className differs from Pending
|
@LockedTerminal Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #450
Checklist
abis/andCOMEBACKHERE-contracts/)Notes
make check-abi-snapshots.