Skip to content

fix: add distinct OnHold visual state to StatusBadge - #557

Open
LockedTerminal wants to merge 1 commit into
WHEELBACK:mainfrom
LockedTerminal:fix/statusbadge-onhold-variant
Open

fix: add distinct OnHold visual state to StatusBadge#557
LockedTerminal wants to merge 1 commit into
WHEELBACK:mainfrom
LockedTerminal:fix/statusbadge-onhold-variant

Conversation

@LockedTerminal

Copy link
Copy Markdown
Contributor

Closes #450

  • Add OnHold to InvoiceStatus enum in comebackhere-frontend types
  • Add badge--on-hold CSS class to App.css (visually distinct from badge--pending via a solid amber border, same warm background tone)
  • Add statusLabels map so OnHold renders as 'On Hold' (human-readable)
  • Update aria-label to use the human-readable label
  • Add StatusBadge.test.tsx covering all 7 status variants with explicit assertions for the new OnHold class, label text, aria-label, and that OnHold className differs from Pending

Checklist

  • Closes #__
  • Tests added or updated
  • ABI snapshot updated if contract sources changed (abis/ and COMEBACKHERE-contracts/)
  • Screenshots attached if UI changed
  • Documentation updated if needed

Notes

  • For contract changes, verify ABI snapshot hygiene with make check-abi-snapshots.
  • For UI changes, include screenshots or screen recordings to help reviewers.

Closes WHEELBACK#258

- Add OnHold to InvoiceStatus enum in comebackhere-frontend types
- Add badge--on-hold CSS class to App.css (visually distinct from
  badge--pending via a solid amber border, same warm background tone)
- Add statusLabels map so OnHold renders as 'On Hold' (human-readable)
- Update aria-label to use the human-readable label
- Add StatusBadge.test.tsx covering all 7 status variants with explicit
  assertions for the new OnHold class, label text, aria-label, and
  that OnHold className differs from Pending
@drips-wave

drips-wave Bot commented Aug 29, 2026

Copy link
Copy Markdown

@LockedTerminal Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: StatusBadge missing a distinct visual state for OnHold invoices

1 participant