Skip to content

fix: warn when grace window is set to zero seconds - #536

Merged
levoski1 merged 1 commit into
WHEELBACK:mainfrom
CodedMumu:fix/grace-window-zero-warning
Aug 30, 2026
Merged

fix: warn when grace window is set to zero seconds#536
levoski1 merged 1 commit into
WHEELBACK:mainfrom
CodedMumu:fix/grace-window-zero-warning

Conversation

@CodedMumu

Copy link
Copy Markdown
Contributor

Closes #458

  • Allow 0 as a valid parseDurationInput value (changed n <= 0 → n < 0)
  • Add non-blocking zeroWarning computed value; shown as an amber alert beneath the input when the entered duration equals zero
  • Save button remains enabled — the warning is informational, not blocking
  • Update confirmMessage to describe a zero-second grace window clearly
  • Add GraceWindowSettings.test.tsx: 4 tests covering warning visibility, positive-value no-warning path, button-enabled-at-zero, and non-integer blocking error path

Pull Request

Summary

  • Describe the purpose of this PR in one or two sentences.

Checklist

  • Closes #__
  • Tests added or updated
  • ABI snapshot updated if contract sources changed (abis/ and COMEBACKHERE-contracts/)
  • Screenshots attached if UI changed
  • Documentation updated if needed

Notes

  • For contract changes, verify ABI snapshot hygiene with make check-abi-snapshots.
  • For UI changes, include screenshots or screen recordings to help reviewers.

Closes WHEELBACK#234

- Allow 0 as a valid parseDurationInput value (changed n <= 0 → n < 0)
- Add non-blocking zeroWarning computed value; shown as an amber alert
  beneath the input when the entered duration equals zero
- Save button remains enabled — the warning is informational, not blocking
- Update confirmMessage to describe a zero-second grace window clearly
- Add GraceWindowSettings.test.tsx: 4 tests covering warning visibility,
  positive-value no-warning path, button-enabled-at-zero, and
  non-integer blocking error path
@drips-wave

drips-wave Bot commented Aug 28, 2026

Copy link
Copy Markdown

@CodedMumu Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@levoski1
levoski1 merged commit 9996b04 into WHEELBACK:main Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: GraceWindowSettings allows saving a grace window of zero seconds without warning

2 participants