Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions .github/scripts/bug-server-gray-scope.test.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
const test = require('node:test');
const assert = require('node:assert/strict');
const fs = require('node:fs');
const os = require('node:os');
const path = require('node:path');
const { spawnSync } = require('node:child_process');
const source = fs.readFileSync(path.join(__dirname, '../workflows/bug-server.yml'), 'utf8');
const gate = / gray-scope:\n([\s\S]*?)\n build:/.exec(source)?.[1];
assert(gate, '缺少独立交接 job');
assert.match(gate, /permissions: \{\}/);
assert.doesNotMatch(gate, /uses:|checkout/);
assert.match(source, / build:\n needs: gray-scope\n if: (?:>-\n )?needs.gray-scope.outputs.skip != 'true'/);
const script = / run: \|\n([\s\S]*)/.exec(gate)[1].replace(/^ /gm, '');
const repository = 'VisActor/VRender';
const original = { EVENT_NAME:'pull_request', HEAD_REF:'fix/normal', HEAD_REPOSITORY:repository, BASE_REPOSITORY:repository,
BASE_REF:'develop', REPOSITORY:repository, HEAD_REPOSITORY_ID:'649514587', BASE_REPOSITORY_ID:'649514587', CREATED_AT:'2026-10-29T08:00:01Z', INTERNAL_SINCE:'' };
const cutoff = String(Date.parse('2026-10-29T08:00:00Z'));

// 直接执行 workflow 的真实 Bash/Python,临时输出在每次调用后回收。
function runGate(env) {
const directory = fs.mkdtempSync(path.join(os.tmpdir(), 'photo-ci-handoff-'));
try {
const output = path.join(directory,'output'); fs.writeFileSync(output,'');
const result = spawnSync('/bin/bash',['--noprofile','--norc','-e','-c',script],{encoding:'utf8',timeout:10000,env:{PATH:'/usr/bin:/bin',...original,...env,GITHUB_OUTPUT:output}});
return { status:result.status, output:fs.readFileSync(output,'utf8'), stderr:result.stderr };
} finally { fs.rmSync(directory,{recursive:true,force:true}); }
}

test('仅新内部 PR 交接;起点未配置、历史、fork、push 和人工入口保持旧流程', () => {
for (const [env,skip] of [
[{},false], [{INTERNAL_SINCE:cutoff},true],
...['main','dev/test','Develop',''].map(BASE_REF => [{INTERNAL_SINCE:cutoff,BASE_REF},false]),
[{INTERNAL_SINCE:cutoff,CREATED_AT:'2026-10-29T08:00:00Z'},false],
[{INTERNAL_SINCE:cutoff,CREATED_AT:'2026-10-29T07:59:59Z'},false],
[{INTERNAL_SINCE:cutoff,DRAFT:'true'},true],
[{INTERNAL_SINCE:cutoff,HEAD_REPOSITORY:'contributor/repo'},false],
[{INTERNAL_SINCE:cutoff,HEAD_REPOSITORY:repository.toUpperCase()},false],
[{INTERNAL_SINCE:cutoff,BASE_REPOSITORY:'contributor/repo'},false],
[{INTERNAL_SINCE:cutoff,REPOSITORY:'contributor/repo'},false],
[{INTERNAL_SINCE:'invalid',EVENT_NAME:'push'},false],
[{INTERNAL_SINCE:'invalid',EVENT_NAME:'workflow_dispatch'},false],
]) {
const result=runGate(env); assert.equal(result.status,0,result.stderr); assert.equal(result.output,`skip=${skip}\n`);
}
});

test('已配置内部交接却元数据或起点非法时停止旧构建,避免重复派发', () => {
for (const env of [
{INTERNAL_SINCE:'invalid'}, {INTERNAL_SINCE:'0'}, {INTERNAL_SINCE:'8640000000000001'},
{INTERNAL_SINCE:'1e12'}, {INTERNAL_SINCE:'1793257200000;echo injected'},
{HEAD_REPOSITORY_ID:'124'}, {BASE_REPOSITORY_ID:'123',HEAD_REPOSITORY_ID:'123'}, {BASE_REPOSITORY_ID:'0',HEAD_REPOSITORY_ID:'0'},
{CREATED_AT:''}, {CREATED_AT:'2026-02-30T08:00:00Z'}, {CREATED_AT:'2026-10-29T08:00:01'},
{CREATED_AT:'2026-10-29T08:00:01+00:00'},
]) { const result=runGate({INTERNAL_SINCE:cutoff,...env}); assert.notEqual(result.status,0); assert.equal(result.output,''); }
});
50 changes: 48 additions & 2 deletions .github/workflows/bug-server.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,56 @@ permissions:
contents: read

jobs:
gray-scope:
# 无权限、不检出仓库;仅以 GitHub 事件元数据和受控起点交接旧 Photo。
runs-on: ubuntu-latest
permissions: {}
outputs:
skip: ${{ steps.scope.outputs.skip }}
steps:
- id: scope
shell: bash
env:
EVENT_NAME: ${{ github.event_name }}
HEAD_REPOSITORY: ${{ github.event.pull_request.head.repo.full_name }}
BASE_REPOSITORY: ${{ github.event.pull_request.base.repo.full_name }}
BASE_REF: ${{ github.event.pull_request.base.ref }}
HEAD_REPOSITORY_ID: ${{ github.event.pull_request.head.repo.id }}
BASE_REPOSITORY_ID: ${{ github.event.pull_request.base.repo.id }}
CREATED_AT: ${{ github.event.pull_request.created_at }}
REPOSITORY: ${{ github.repository }}
INTERNAL_SINCE: ${{ vars.VISACTOR_WORKFLOW_INTERNAL_SINCE }}
run: |
# 仅交接目标 develop;其他分支保留旧 Photo,新 Draft 等待 ready。
skip=$(python3 - <<'PY'
import os, re
from datetime import datetime
e = os.environ
skip = False
if (e['EVENT_NAME'] == 'pull_request' and e['REPOSITORY'] == 'VisActor/VRender'
and e['HEAD_REPOSITORY'] == e['BASE_REPOSITORY'] == e['REPOSITORY']
and e['BASE_REF'] == 'develop' and e['INTERNAL_SINCE']):
# 已配置交接却缺失可信元数据时停止旧构建,避免两套 Photo 同时执行。
since = e['INTERNAL_SINCE']
if not re.fullmatch(r'[1-9][0-9]{0,15}', since) or int(since) > 8640000000000000:
raise SystemExit('Invalid VISACTOR_WORKFLOW_INTERNAL_SINCE')
if e['BASE_REPOSITORY_ID'] != '649514587' or e['HEAD_REPOSITORY_ID'] != e['BASE_REPOSITORY_ID']:
raise SystemExit('Invalid internal repository identity')
created = e['CREATED_AT']
if not re.fullmatch(r'[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}Z', created):
raise SystemExit('Invalid PR creation time')
skip = int(datetime.fromisoformat(created.replace('Z', '+00:00')).timestamp() * 1000) > int(since)
print('true' if skip else 'false')
PY
)
echo "skip=$skip" >> "$GITHUB_OUTPUT"

build:
needs: gray-scope
if: >-
github.event_name == 'push' ||
(github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository)
needs.gray-scope.outputs.skip != 'true' &&
(github.event_name == 'push' ||
(github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository))
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/unit-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ jobs:
# run: |
# fc-list

- name: Photo CI handoff contract tests
run: node --test .github/scripts/bug-server-gray-scope.test.cjs

# Install rush
- name: Install native deps for node-canvas (macOS)
if: runner.os == 'macOS'
Expand All @@ -41,6 +44,8 @@ jobs:
run: node common/scripts/install-run-rush.js update --bypass-policy
- name: Install rush
run: node common/scripts/install-run-rush.js install --bypass-policy
- name: Visual runner contract tests
run: node --test packages/vrender/scripts/visual-test.test.mjs
- name: Source tests (without build artifacts)
run: node common/scripts/install-run-rush.js test --only tag:package
- run: node common/scripts/install-run-rush.js build --only tag:package
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -101,3 +101,6 @@ spec-types
*.tsbuildinfo
.omx/
.worktrees/

# 本地视觉运行产物
.vrender-visual/
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -136,3 +136,7 @@ Small streams converge to make great rivers and seas!
# License

[MIT License](./LICENSE)

## Playwright 视觉回归

首批用例、运行命令、报告协议和维护说明见[本地视觉回归指南](packages/vrender/__tests__/visual/README.md)。该入口不改变现有 Photo CI 或生产工作流启用范围。
4 changes: 4 additions & 0 deletions README.zh-CN.md
Original file line number Diff line number Diff line change
Expand Up @@ -137,3 +137,7 @@ st.defaultLayer.add(sy);
# 许可证

[MIT 协议](./LICENSE)

## Playwright 视觉回归

首批用例、运行命令、报告协议和维护说明见[本地视觉回归指南](packages/vrender/__tests__/visual/README.md)。该入口不改变现有 Photo CI 或生产工作流启用范围。
41 changes: 37 additions & 4 deletions common/config/rush/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

58 changes: 58 additions & 0 deletions packages/vrender/__tests__/visual/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
# VRender 本地视觉回归

在 Chromium 中对当前工作区和官方 `VisActor/VRender develop` 的构建逐例比较。两侧使用冻结的同一套用例和断言,仅替换 SDK。协议沿用 VChart/VTable 串行运行器:完整 SHA、逐侧依赖校验、两侧构建、原生 Playwright 比较和可搬迁报告。首期 6 项代表用例,不代表 VRender 全功能、多浏览器或多端通过;不替代单测和 BugServer Photo。

运行器与报告基础复用 VChart `0b14ff87f9cc3970248c26f4ce9ecd50d9d82262` 的串行实现,仅适配 VRender 构建和页面。后续协议修复应对照两仓同步,不另建共享运行时服务。

## 准备与运行

使用 Node.js 22 或 24(产品 CI 使用 24),安装锁文件依赖和 Playwright 1.63.0 对应 Chromium;Linux 还需要浏览器系统库。

```sh
node common/scripts/install-run-rush.js install --ignore-hooks
PLAYWRIGHT_SKIP_BROWSER_GC=1 node packages/vrender/node_modules/@playwright/test/cli.js install chromium
node packages/vrender/scripts/visual-test.mjs --check
node packages/vrender/scripts/visual-test.mjs --list
node packages/vrender/scripts/visual-test.mjs --self-compare
node packages/vrender/scripts/visual-test.mjs --case picking-events
node packages/vrender/scripts/visual-test.mjs --baseline <完整40位SHA>
node packages/vrender/scripts/visual-test.mjs
node --test packages/vrender/scripts/visual-test.test.mjs
# 使用已经通过的真实报告执行负对照(不改源码/标准图)
VRENDER_VISUAL_FIXTURE=<报告绝对目录> node --test packages/vrender/scripts/visual-negative.test.mjs
```

不传筛选参数运行清单全部用例;`--case` 和 `--dir` 互斥,`--dir` 按用例子目录选择(首批用例位于根目录)。默认从固定官方地址获取 develop,fork origin 不参与解析。`--self-compare` 使用同一构建、两个浏览器上下文,仅用于确定性检查,不是正式 head/base 验证。SDK 使用既有 bundler,依次构建 core、kits、animate、components 的 ES 及主包 UMD;不会修改产品运行时代码。

隔离执行:`--baseline <完整SHA> --offline`。宿主预先准备两侧 Git 提交、依赖和浏览器,分别通过 `VISUAL_HEAD_DEPENDENCIES` / `VISUAL_BASELINE_DEPENDENCIES` 指定快照。每侧完整工程清单和配置须与其 SHA 一致,缺失或错配即失败;执行时不联网 fetch/install。新增运行器无需基线提交已经包含运行器,两侧均使用候选冻结套件。正式 Bot 准入只消费全量范围,单例和自比较不用于判定全量通过。

## 首批覆盖

| ID | 场景与断言 |
| --- | --- |
| primitives-text | 矩形、圆、中文/数字文本;有效边界及非空白绘制 |
| transform-clip | 分组平移、缩放、裁剪;裁剪内外真实像素 |
| picking-events | 真实鼠标悬停/点击;顶层命中、事件计数及未穿透下层 |
| tag-component | Tag 背景、文本及更新后的内容/尺寸 |
| attribute-update | 属性更新后几何与拾取位置同步 |
| stage-lifecycle | 独立 Stage 销毁后画布移除,主 Stage 继续正常绘制 |

固定画布、视口、DPR、UTC、字体与输入;无外部资源和随机数据。必须等待两张连续截图一致。比较沿用 `threshold=0.1 / maxDiffPixels=0`,不以放宽阈值解决不稳定。动画时序、多端环境、复杂组件及性能不在首批范围。

## 报告与失败处理

产物位于 Git 忽略的 `.vrender-visual/runs/<run-id>/`:

- `index.html`:基线/当前/差异图;整体复制目录以保留相对链接。
- `agent-summary.md` 与 `summary.json`:问题摘要及 schemaVersion=1 结构化证据,含 head/base、源码摘要、用例集合、SDK 摘要、阶段结果和真实错误。
- `build.log`、两侧 Playwright 报告、PNG 和失败 trace:排查构建、资源、交互及截图问题。

退出码 `0` 为所选用例通过,`1` 为视觉差异,`2` 为执行/构建/资源/清理错误。缺图、漏项、未执行、超时不得算通过。基线显式业务断言失败而当前通过时保留 `new_baseline` 证据供人工调查,不自动接受或更新标准图。先看报告错误分类,再按记录 SHA 和命令复现;禁止用跳过断言或接受差异代替修复。

正常、异常和 Ctrl+C 都回收本轮子进程、浏览器、HTTP 服务和基线 worktree。SIGKILL/断电后检查 `git worktree list` 及 `.vrender-visual/running.lock/owner.json`,确认所属进程结束后才处理残留,勿清理其他任务资源。

## 添加用例

在 `cases/` 新增模块并在 `cases/index.mjs` 显式登记稳定 ID、中文目的和文件路径。模块必须可被 Node/浏览器导入:`createSpec(VRender, stage)` 创建图形并返回供断言使用的对象;可选 `exercise(page)` 执行交互;`verify(page)` 核对真实业务结果。仅明确的业务不符使用 `assertionError`,不得把资源/浏览器异常包装成业务失败。新增后运行自检、自比较和冻结基线比较,并证明可见变化/错误行为能被检测。

本入口合入不代表 AI PR 工作流已上线。旧 Photo CI 已准备独立的 `gray-scope` 判断,`VISACTOR_WORKFLOW_INTERNAL_SINCE` 未配置时保持原有触发。启用后仅交接仓库 ID 649514587、同仓、目标 develop 且创建时间晚于起点的新 PR;新 Draft 同样交接并由 Bot 等待 ready。存量、fork、其他目标、main push 和维护者手动入口保持原职责。起点或仓库身份非法时停止旧构建,避免重复派发。该变量必须与 Bot discovery.createdAfter、BugServer 服务身份 internalSince 一致,并在起点前完成存量快照;本提交不设置变量或变更生产调度,正式切流另行验收与授权。
14 changes: 14 additions & 0 deletions packages/vrender/__tests__/visual/assertions.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
/** 仅在显式业务状态比较失败处构造;不要包装浏览器或页面 API 的执行异常。 */
export function assertionError(message) {
const error = new Error(message);
error.name = 'VisualAssertionError';
return error;
}

/** 识别显式业务断言,包括 Playwright 跨 page.evaluate 序列化后的首行类型标记。 */
export function isBusinessAssertion(error) {
return (
error.name === 'VisualAssertionError' ||
/^(?:Error: )?(?:(?:page|frame)\.evaluate(?:Handle)?: )?VisualAssertionError: /.test(String(error.message ?? ''))
);
}
15 changes: 15 additions & 0 deletions packages/vrender/__tests__/visual/cases/attribute-update.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import { assertionError } from '../assertions.mjs';

/** 属性更新同步改变几何与拾取位置。 */
export function createSpec(v, stage) {
const rect=v.createRect({x:40,y:50,width:100,height:60,fill:'#3366cc'});stage.defaultLayer.add(rect);return {rect};
}

/** 通过真实浏览器操作或公开 API 执行交互。 */
export async function exercise(page) { await page.evaluate(()=>{window.__visualObjects.rect.setAttributes({x:220,width:160,fill:'#e8684a'});window.__visualStage.render();}); }

/** 显式核对业务结果,空白截图不能替代语义成功。 */
export async function verify(page) {
const ok=await page.evaluate(()=>{ const {rect}=window.__visualObjects;const stage=window.__visualStage;return rect.attribute.x===220 && stage.pick(250,80).graphic===rect && !stage.pick(60,80); });
if (!ok) throw assertionError('属性更新同步改变几何与拾取位置断言失败');
}
Loading
Loading