Repository navigation
fix: use VRender clone for delayed input events - #4737
Merged
xile611 merged 1 commit intoNov 11, 2026
Merged
Conversation
xile611
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related PR link
Follow-up to #4725, using the fix released in VisActor/VRender#2156.
🐞 Bugserver case id
Administrator follow-up pending. Reproduction coverage is in
packages/vchart/__tests__/unit/event/event-delay.test.ts, including root pointer/wheel events and real Gesture pinch payloads through Compiler.💡 Background and solution
Delayed input handlers in #4725 manually copied VRender events because 1.1.14 lost extension payloads and could not clone root events. VRender 1.1.15 fixes both problems, so use
event.clone()and remove the temporary field-copying logic.Upgrade the five VRender packages to 1.1.15 across the workspace and update the lockfile to keep Rush's dependency versions consistent. Extend the existing managed/root-event regression to check the upstream clone contract: payloads and detached coordinate/path buffers are preserved, dispatch state is reset, and the original event is unchanged. Synchronous handlers continue to receive the original event.
No visual changes are expected.
📝 Changelog
currentTarget, according to VRender's clone contract.☑️ Self-Check before Merge
Validation:
--noEmit, changed TypeScript files' Prettier check,git diff --check, Rush dependency consistency check, and frozen-lockfile install passed. ESLint reports no errors and two pre-existinganywarnings.308609fd89bfbae98741f39218d88bcc24118840: 270/270 passed, 0 diffs, 0 new baselines, 0 errors, 0 not run. Command:node packages/vchart/scripts/visual-test.mjs --baseline 308609fd89bfbae98741f39218d88bcc24118840 --offline. Candidate7397cbd128a1019341f13fcaaea08ad34dee73cbremained clean throughout the run. This includes the Gesture delay, throttle propagation, and subscription ownership browser cases.Physical mobile-device validation has not run. Remote CI will run separately. Repository commit/push hooks were bypassed for this verified change because of the existing shell/Rush bootstrap incompatibility; the explicit checks above were run separately.
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough