Skip to content

fix: use VRender clone for delayed input events - #4737

Merged
xile611 merged 1 commit into
VisActor:developfrom
g1f9:fix/use-vrender-event-clone-20261110
Nov 11, 2026
Merged

xile611 merged 1 commit into
VisActor:developfrom
g1f9:fix/use-vrender-event-clone-20261110

Conversation

@g1f9

@g1f9 g1f9 commented Nov 10, 2026

Copy link
Copy Markdown

🤔 This is a ...

  • Bug fix
  • Update dependency

🔗 Related PR link

Follow-up to #4725, using the fix released in VisActor/VRender#2156.

🐞 Bugserver case id

Administrator follow-up pending. Reproduction coverage is in packages/vchart/__tests__/unit/event/event-delay.test.ts, including root pointer/wheel events and real Gesture pinch payloads through Compiler.

💡 Background and solution

Delayed input handlers in #4725 manually copied VRender events because 1.1.14 lost extension payloads and could not clone root events. VRender 1.1.15 fixes both problems, so use event.clone() and remove the temporary field-copying logic.

Upgrade the five VRender packages to 1.1.15 across the workspace and update the lockfile to keep Rush's dependency versions consistent. Extend the existing managed/root-event regression to check the upstream clone contract: payloads and detached coordinate/path buffers are preserved, dispatch state is reset, and the original event is unchanged. Synchronous handlers continue to receive the original event.

No visual changes are expected.

📝 Changelog

Language Changelog
English Upgrade VRender to 1.1.15 and use its event cloning for debounced/throttled input callbacks. Delayed clones now reset dispatch state, including currentTarget, according to VRender's clone contract.
Chinese 升级 VRender 至 1.1.15,延迟事件回调直接使用上游 clone,移除临时手工复制逻辑;延迟副本按 VRender 契约重置 currentTarget 等派发状态。

☑️ Self-Check before Merge

  • Test results and the reasons for any unrun checks are documented.
  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Validation:

  • Five related event/Compiler suites: 76 tests passed in Node and the same 76 passed in Electron under Xvfb.
  • Public VChart event suite: 19 tests passed in Electron.
  • Negative control: restoring the old manual copy makes both managed/root dispatch-state regression cases fail; the final implementation passes.
  • VChart TypeScript --noEmit, changed TypeScript files' Prettier check, git diff --check, Rush dependency consistency check, and frozen-lockfile install passed. ESLint reports no errors and two pre-existing any warnings.
  • Full visual suite against develop 308609fd89bfbae98741f39218d88bcc24118840: 270/270 passed, 0 diffs, 0 new baselines, 0 errors, 0 not run. Command: node packages/vchart/scripts/visual-test.mjs --baseline 308609fd89bfbae98741f39218d88bcc24118840 --offline. Candidate 7397cbd128a1019341f13fcaaea08ad34dee73cb remained clean throughout the run. This includes the Gesture delay, throttle propagation, and subscription ownership browser cases.

Physical mobile-device validation has not run. Remote CI will run separately. Repository commit/push hooks were bypassed for this verified change because of the existing shell/Rush bootstrap incompatibility; the explicit checks above were run separately.


🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@visactor-review-bot visactor-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No confirmed new issues found.

@xile611
xile611 merged commit f837ddc into VisActor:develop Nov 11, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants