Skip to content

Include ontology classes in TermsForPub - #130

Merged
Robbie1977 merged 1 commit into
mainfrom
fix/terms-for-pub-classes
Oct 23, 2026
Merged

Robbie1977 merged 1 commit into
mainfrom
fix/terms-for-pub-classes

Conversation

@Robbie1977

Copy link
Copy Markdown
Contributor

TermsForPub's has_reference branch matched only Individuals. FBbt classes cite papers for their definitions and synonyms, so anatomy papers cited only by classes returned nothing — e.g. Li et al. 2020 (FBrf0248215) is referenced by mushroom body (FBbt_00005801) and 107 other classes but the query returned 0.

  • Match Individuals and Classes; exclude Deprecated terms.
  • Type column: INSTANCEOF class for Individuals, direct SUBCLASSOF parent(s) for Classes.
  • Reference type now comes from the edge typ: Definition / Synonym / Text-mined / Reference (DataSets) / Expression.
  • Regression tests for FBrf0248215 (classes) and FBrf0227179 (DataSet still present).

Against pdb: FBrf0248215 0 → 108, FBrf0227179 86 → 214, FBrf0242477 127 → 449; no previously returned row is lost. Eckstein 2024 (9,691 terms) runs in ~3 s uncached.

After release, cached v3-cached entries for affected pubs need an X-Force-Refresh to drop the stale count: 0.

The has_reference branch matched only Individuals, but FBbt classes
cite papers for their definitions and synonyms. Anatomy papers such as
Li et al. 2020 (FBrf0248215) are cited only by classes, so the query
returned nothing.

Match Individuals and Classes, excluding Deprecated terms. Show the
SUBCLASSOF parent(s) as Type for class rows. Report why each term cites
the pub (Definition, Synonym, Text-mined, Reference, Expression) from the
edge typ. Add regression tests for both kinds.
@Robbie1977
Robbie1977 merged commit 39412ee into main Oct 23, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant