Repository navigation
Serve DataSet summaries from VFBquery term info - #293
Merged
Merged
Conversation
The Neo4j 'Get JSON for DataSet' query walks has_source|SUBCLASSOF|INSTANCEOF* unbounded and can run for many minutes on large datasets. get_DataSet_TermInfo (summary=True) now maps VFBquery's cached get_term_info onto the same summary dict, falling back to Neo4j for anything it cannot serve. summary=False is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_DataSet_TermInfo(summary=True)now builds its summary from VFBquery's cached/get_term_infoinstead of the Neo4jGet JSON for DataSetCypher, which walkshas_source|SUBCLASSOF|INSTANCEOF*unbounded and can run for many minutes on large datasets (Neo4j 4.4 on the cluster pdb).cached_query.dataset_summary_from_term_infomaps VFBquery -> the existing summary keys (label, symbol, id, tags, description, miniref, FlyBase, PMID, DOI).summary=Falseunchanged (VFBquery doesn't return the raw legacy JSON).Checked against the legacy output for Ito2013: label, id, description, miniref, FlyBase, PMID and DOI are identical. Differences:
symbolis always''(not in VFBquery; empty for datasets anyway),tagscome from VFBquery SuperTypes (Ito2013 lacks the legacyAdult), and DOI is now returned even when there is no PubMed ID (legacy gated it on PubMed, a bug).