Repository navigation
Keep the settings menu inside the iOS safe areas - #1748
Open
SpikeViper wants to merge 1 commit into
Open
SpikeViper wants to merge 1 commit into
SpikeViper wants to merge 1 commit into
Conversation
On iPhone the full-screen settings menu drew its title bar and close button under the status bar clock. At the phone breakpoint the menu now pads its contents by the safe-area insets while its background still fills the screen, and the close button moves down with them. On larger screens the centred menu's maximum size leaves the insets clear. The insets are zero in browsers and on desktop, so only iOS changes.
Deploying valour-marketing with
|
| Latest commit: |
3ed5044
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3c71f3ae.valour-marketing.pages.dev |
| Branch Preview URL: | https://fix-ios-modal-safe-area.valour-marketing.pages.dev |
Deploying valour with
|
| Latest commit: |
3ed5044
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8a4b2f5d.valour.pages.dev |
| Branch Preview URL: | https://fix-ios-modal-safe-area.valour.pages.dev |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iPhone, the full-screen settings menu (account settings, planet settings) drew its title bar and close button under the status bar clock. Found while taking the App Store in-app purchase review screenshots.
env(safe-area-inset-*)while its background still fills the screen, and the close button moves down and in by the same amounts.max-heightandmax-widthsubtract the insets, so it can't reach under the status bar or home indicator.env(safe-area-inset-*)is 0 in browsers and the desktop apps, so only iOS changes.Checked on an iPhone 17 Pro simulator (iOS 26.5) running a local Debug build: the "General Settings" bar now sits below the status bar, with the close button clear of it.