Repository navigation
fix: pdf preview error when dummy data is not set - #1927
Open
simonfernandes wants to merge 1 commit into
Open
simonfernandes wants to merge 1 commit into
simonfernandes wants to merge 1 commit into
Conversation
simonfernandes
requested review from
a team and
bolmsten
and removed request for
a team
October 27, 2026 17:18
simonfernandes
requested review from
EdwardHaynes and
joshpme
and removed request for
a team
October 27, 2026 17:18
ellen-wright
approved these changes
Oct 28, 2026
EdwardHaynes
approved these changes
Nov 3, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small fix to the ESR and proposal PDF previews to stop trying to load a preview when the dummy data required for it is empty (i.e. not set).
Motivation and Context
We were getting some production errors in our logs.
How Has This Been Tested
Manual testing
Fixes
UserOfficeProject/issue-tracker#1755
Changes
Depends on
Tests included/Docs Updated?