Repository navigation
feat: allow accessing ESR features without Scheduler feature enabled - #1819
Merged
Merged
Conversation
SourangshuSTFC
changed the title
SourangshuSTFC
changed the title
SourangshuSTFC
marked this pull request as ready for review
October 26, 2026 14:20
SourangshuSTFC
requested review from
simonfernandes
and removed request for
a team
October 26, 2026 14:20
yoganandaness
approved these changes
Oct 28, 2026
simonfernandes
left a comment
simonfernandes
left a comment
Contributor
There was a problem hiding this comment.
This looks good but I just wanted to check - in the description you mentioned this should affect the Instrument Scientist and User Officer roles, but it looks like this would only affect Experiment Safety Reviewers?
Contributor
Author
Hi @simonfernandes my bad, I have updated the change description, I had mixed it up with another change I was working on. |
simonfernandes
approved these changes
Oct 28, 2026
SourangshuSTFC
enabled auto-merge
October 29, 2026 11:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to UserOfficeProject/issue-tracker#1731
Motivation and Context
STFC needs to access the Experiments related pages and features for performing Experiment Safety Review initially for Technique Proposals and then for general proposals. This is discussed and a go ahead been given in #1799
Currently, to visit Experiments page to view experiments or initiate Experiment Safety Review, the Scheduler feature flag needs to be checked under Features section, or needs to be preset via config. This dependency is not currently required for STFC as STFC will continue to use the existing Scheduler, according to latest discussion. Hence, the dependency on this check can be disabled now.
Note: re-check to be done by other facilities like ESS in case this
How Has This Been Tested
UOP/core frontend and backend has been spun up in local and when accessing as User Officer role, the Experiments options can be seen in side Menu.
Fixes
Changes
In UO Core frontend: apps/frontend/src/components/menu/MenuItems.tsx
the isSchedulerEnabled check has been removed for role Experiment Safety Reviewer.
Depends on
Tests included/Docs Updated?