Repository navigation
fix: fix proposals fap review counts - #1814
Merged
Merged
Conversation
TCMeldrum
requested review from
ellen-wright
and removed request for
a team
September 21, 2026 10:53
jekabs-karklins
self-requested a review
September 21, 2026 12:00
Scott-James-Hurley
approved these changes
Sep 28, 2026
jekabs-karklins
requested changes
Oct 1, 2026
jekabs-karklins
approved these changes
Nov 3, 2026
jekabs-karklins
left a comment
jekabs-karklins
left a comment
Contributor
There was a problem hiding this comment.
Fix looks good so I approve just one thong for the failing e2e . e2e is failing because test saves a review only as a draft and then expects 1 / 1, but this PR now counts only submitted reviews, so the page correctly shows 0 / 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes UserOfficeProject/issue-tracker#1729
Description
This PR addresses an issue with incorrect review counts on the FAP Proposals page.
Motivation and Context
Previously, the review count was based on the number of graded proposals, which did not correctly reflect the actual number of reviews. Now, the count is determined by the number of submitted proposals, which provides a more accurate representation of the review process.
Changes
ReviewStatusto the imports from 'generated/sdk'.gradedProposalsvariable tosubmittedProposalsto better represent its purpose.assignment.review.grade !== nulltoassignment.review.status === ReviewStatus.SUBMITTED. This ensures that only submitted reviews are counted.How Has This Been Tested?
Fixes Jira Issue
https://jira.ess.eu//browse/
Depends On
Tests included/Docs Updated?