Repository navigation
fix: filter out sample questionary fields with skip_metadata natural key - #746
Merged
jekabs-karklins merged 1 commit intoOct 30, 2026
Conversation
jekabs-karklins
changed the title
jekabs-karklins
requested review from
Junjiequan and
nitrosx
and removed request for
Junjiequan
October 30, 2026 11:17
jekabs-karklins
enabled auto-merge
October 30, 2026 11:50
nitrosx
approved these changes
Oct 30, 2026
jekabs-karklins
deleted the
SWAP-5915-connector-filter-out-sample-questionary-fields-wi
branch
October 30, 2026 12:01
nitrosx
requested changes
Oct 30, 2026
nitrosx
left a comment
nitrosx
left a comment
Contributor
There was a problem hiding this comment.
can you please add logging.
In the logs, I would like to see which one is passed along in SciCat and which one is skipped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sample questionary fields whose natural key starts with
skip_metadataare no longer sent to SciCat as sample characteristics.Changes
skip_metadata*fields when building sample characteristicsnaturalKeyto the UO experiment sample question typegetCreateScicatSampleDto