Defer TTL-expired catalog refresh off the read path - #1615
Draft
RhysSullivan wants to merge 8 commits into
Draft
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | ad87861 | Aug 16 2026, 09:39 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | ad87861 | Commit Preview URL Branch Preview URL |
Aug 16 2026, 09:40 PM |
Contributor
Cloudflare preview
Sign-in is Cloudflare Access (one-time PIN to an allowed email). The preview has its own database and encryption key; it is destroyed when this PR closes. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1612.
TTL expiry is speculative ("maybe the server changed") — unlike drift signals, nothing about the next read's correctness depends on it, so it should never block a response.
ExecutorConfig.deferToolSyncseam: expired-only candidates are batched (cap 16, overflow counted) into one background task; the claim is taken inside the task, so a dropped batch strands no lease. Absent seam = the same batch runs inline and its outcomes count in the terminal partition;deferredcounts only work genuinely handed away.ctx.waitUntilwith the Effect tracer provided and a bounded flush (a barerunPromisewould have silently dropped every background sync span). Long-lived hosts (local, selfhost) fork a daemon fiber. host-cloudflare has no tracer at all; documented./api/*plane deliberately stays inline: the request-scoped postgres pool is released before the response is written (pinned by a new ordering test), so there is no post-response window to defer into, and deferring the scope close would reintroduce the unbounded-socket teardown this codebase already fixed once. Expired work there remains filter-scoped, claim-deduped, and backoff-bounded from the earlier layers.Not included, needs a product decision: an e2e for the expired trigger requires plumbing
toolsSyncTtlMsthrough host config + an env knob (the 15-min default is unreachable in e2e without banned DB pokes or sleeps). The wire-level MCP test covers the stale-serve/drain/converge guarantee one layer down.