docs(a2a): drop drifting line numbers from store method docs - #217
Open
FanouZeng-TT wants to merge 1 commit into
Open
docs(a2a): drop drifting line numbers from store method docs#217FanouZeng-TT wants to merge 1 commit into
FanouZeng-TT wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Three A2A docs pin
store.pymethods to fixed source line numbers that havedrifted as
a2a/business_agent/src/business_agent/store.pyevolved:01-architecture.mdstart_payment()01-architecture.mdplace_order()04-commerce-flows.md_get_fulfillment_options()04-commerce-flows.mdplace_order()06-extending.mdstart_payment()06-extending.md_get_fulfillment_options()The
01-architecture.md"Key Methods" table also lists aLinecolumn whoseadd_to_checkout(186 vs 183) andget_checkout(244 vs 241) values arealready wrong and will keep advancing. Line numbers are volatile navigation
state; the method names and file path already locate the implementation.
Fix: remove the drifting line markers while keeping the method names and
store.pyfile reference, so the docs stop navigating readers to the wrongsource lines.
Category (Required)
Related Issues
N/A
Checklist
generate_models.shunderpython_sdk.Screenshots / Logs (if applicable)
rg -n '^ def ' store.pyconfirms current definitions (452/484/511); nostore.py:<line>or(line N)references remain for these methods.uvx pre-commit run --all-files: passedgit diff --check: passed