Skip to content

fix(secrets): skip template secrets the organization already provides - #35

Merged
JheisonMB merged 1 commit into
developfrom
fix/org-provided-secrets
Oct 6, 2026
Merged

JheisonMB merged 1 commit into
developfrom
fix/org-provided-secrets

Conversation

@JheisonMB

Copy link
Copy Markdown
Contributor

The rust and python boilerplates declare a required secret (CARGO_REGISTRY_TOKEN, PYPI_API_TOKEN). The wizard (step 9) and ghscaff apply (step 6) always asked for it — or silently took the vault's copy — and wrote it as a repo secret. In an organization that shares the secret (UniverLab now has one org-level CARGO_REGISTRY_TOKEN), that repo copy shadows the shared one, so rotating the token in one place stops working for that repo.

  • github::secrets::list_org_secret_names: GET /repos/{owner}/{repo}/actions/organization-secrets; a user-owned repo answers 422, which (like any failure) reads as none, so personal repos keep today's behaviour.
  • templates::secrets_to_configure: the template secrets neither on the repo nor provided by its organization.
  • Wizard: prints ◆ Secret X: provided by the organization and skips it; apply: counts org secrets as present.

Checked: clippy -D warnings, nextest 846 passed, rust-quality.sh PASSED; the endpoint verified by hand — UniverLab/cadspec lists CARGO_REGISTRY_TOKEN, JheisonMB/demo-ghscaff answers 422.

🤖 Generated with Claude Code

https://claude.ai/code/session_01JeZdT4Zae1BxeLEoKd6kEs

@JheisonMB
JheisonMB merged commit e26a842 into develop Oct 6, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant