Skip to content

Prevent duplicated extension names from being set in Vulkan CreateInfo - #1126

Open
vildninja wants to merge 1 commit into
Unity-Technologies:mainfrom
vildninja:main
Open

vildninja wants to merge 1 commit into
Unity-Technologies:mainfrom
vildninja:main

Conversation

@vildninja

Copy link
Copy Markdown

Fixed the code responsible for removing duplicated extension names in Hook_vkCreateDevice and Hook_vkCreateInstance, when merging ppEnabledExtensionNames with requestedDeviceExtensions and requestedInstanceExtensions.

The previous error caused a startup crash on Android for the Galaxy Tab Active3. Our newer Android devices just posts a warning.

// Logcat from Galaxy Tab Active5
D  [Vulkan init] extensions: name=VK_EXT_debug_report [enabled=0, external=0]
D  [Vulkan init] extensions: name=VK_EXT_debug_utils [enabled=1, external=0]
D  [Vulkan init] extensions: name=VK_EXT_surface_maintenance1 [enabled=0, external=0]
D  [Vulkan init] extensions: name=VK_EXT_swapchain_colorspace [enabled=1, external=0]
D  [Vulkan init] extensions: name=VK_GOOGLE_surfaceless_query [enabled=0, external=0]
D  [Vulkan init] extensions: name=VK_KHR_android_surface [enabled=1, external=0]
D  [Vulkan init] extensions: name=VK_KHR_device_group_creation [enabled=0, external=0]
D  [Vulkan init] extensions: name=VK_KHR_external_fence_capabilities [enabled=1, external=0]
D  [Vulkan init] extensions: name=VK_KHR_external_memory_capabilities [enabled=1, external=0]
D  [Vulkan init] extensions: name=VK_KHR_external_semaphore_capabilities [enabled=1, external=0]
D  [Vulkan init] extensions: name=VK_KHR_get_physical_device_properties2 [enabled=1, external=0]
D  [Vulkan init] extensions: name=VK_KHR_get_surface_capabilities2 [enabled=0, external=0]
D  [Vulkan init] extensions: name=VK_KHR_surface [enabled=1, external=0]
D  [Vulkan init] extensions: name=VK_KHR_surface_protected_capabilities [enabled=0, external=0]
// RIP Active3
I  CreateInfoWrapper::FilterExtension: already have 'VK_KHR_external_memory_capabilities'.
I  CreateInfoWrapper::FilterExtension: already have 'VK_KHR_external_semaphore_capabilities'.
I  CreateInfoWrapper::FilterExtension: already have 'VK_KHR_get_physical_device_properties2'.

Possibly related to #437 and #1120

#437 (comment)

@cla-assistant-unity

cla-assistant-unity Bot commented Sep 11, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant