Repository navigation
add_keywords: fast mode by default - #48
Merged
Merged
Conversation
Co-authored-by: Cursor <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add_keywordsnow runs fast mode by default (fast=True), and the request always names the mode:{"mode": "fast"}or, withfast=False,{"mode": "product"}. Before, the default sent no body and got the server's default, per-product. Fast mode is 6 to 10 times faster (a 19,000-item catalog took 12 minutes, against 1 to 2 hours per 20,000 items per product), with about 3 keywords per item instead of 9.Docstrings,
docs/catalogs.md, the README comment and the embed-catalog skill now describe fast mode as the default andfast=Falseas the slower option with more keywords.embed(..., keywords=True)has no mode in the API; it takes the worker's default, which Unbox-AI/unbox-worker#7 sets to fast. Its docstring here assumes that is deployed, so release this after the worker.This changes a default, so it should go out as a minor release.