Add timeout to NSI client and enhance error handling - #136
Open
jlgutenson wants to merge 1 commit into
Open
Conversation
Added timeout to NSI HTTP client and improved error handling for NSI API responses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had some trouble using NSI API today while testing go-consequences. It looks like the API may have been updated with 2026 data recently and some additional changes may have occurred. These updates fixed the issue I was having and I wanted to share them.
Mainly, the issue seemed to be that the NSI endpoint emits JSON text sequences where records can be prefixed by ASCII record separator bytes. The updated code stripped those bytes before passing the stream to json.Decoder, which expects plain JSON tokens.
Also, this added a timeout to NSI HTTP client and (hopefully) improved error handling for NSI API responses.