Bugfix: Added defaults to optional query parameters for water contract creation - #1891
Open
zack-rma wants to merge 2 commits into
Open
Bugfix: Added defaults to optional query parameters for water contract creation#1891zack-rma wants to merge 2 commits into
zack-rma wants to merge 2 commits into
Conversation
zack-rma
marked this pull request as ready for review
August 21, 2026 21:07
oskarhurst
suggested changes
Aug 21, 2026
oskarhurst
left a comment
oskarhurst
left a comment
There was a problem hiding this comment.
Hi the fixes look good but can you also add these same fixes to some other places in the code where the same error still exists, just so we can make sure to knock them all out at once. specifically
WaterUserCreateController.java:85
boolean failIfExists = Boolean.parseBoolean(ctx.queryParam(FAIL_IF_EXISTS));
WaterContractDeleteController.java:85
WaterUserDeleteController.java:84
DeleteMethod deleteMethod = getDeleteMethod(ctx.queryParam(METHOD));
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added defaults to optional query parameters for water contract creation. Previously had optional query parameters parsed into primitive booleans, which would break when parameters were not provided.
Checklist