Actually output the trace context in the docker image. - #1884
Open
MikeNeilson wants to merge 1 commit into
Open
Conversation
MikeNeilson
force-pushed
the
bugfix/actually-output-the-trace-context
branch
from
August 19, 2026 17:59
6e52fdb to
48a0a20
Compare
MikeNeilson
force-pushed
the
bugfix/actually-output-the-trace-context
branch
from
August 20, 2026 22:23
48a0a20 to
33e266e
Compare
oskarhurst
suggested changes
Aug 21, 2026
oskarhurst
left a comment
oskarhurst
left a comment
There was a problem hiding this comment.
I think you changes to Juli might break tomcats logging
| <logger name="org.apache" level="ERROR"/> | ||
|
|
||
| <logger name="org.apache.catalina" level="INFO" additivity="false"> | ||
| <appender-ref ref="STDERR" /> |
| </appender> | ||
| </appender> | ||
|
|
||
| <appender name="OTEL-STDERR" class="io.opentelemetry.instrumentation.logback.mdc.v1_0.OpenTelemetryAppender"> |
There was a problem hiding this comment.
Correct me if I am wrong but isn't OpenTelemetryAppender unshaded so it could never resolve and use the shaded classes provided by juli. Also isn't locgback-juli only run inside of tomcat would would never have any cda trace-ids to begin with so we only need the change in the normal logback file to add the traces ids?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While working on HydrologicEngineeringCenter/cwms-python#305, discovered that while we process the traceparent header, we never actually output the trace_id and span_id for viewing and analysis in the logs.
Related Issue
Closes #
Validation
Describe how this was tested.
Checklist