Skip to content

chore(deps): bump dicom-rs to 0.10 - #67

Merged
nickamzol merged 1 commit into
UMEssen:mainfrom
holg:bump_dicom_0.10
Sep 17, 2026
Merged

nickamzol merged 1 commit into
UMEssen:mainfrom
holg:bump_dicom_0.10

Conversation

@holg

@holg holg commented Sep 14, 2026

Copy link
Copy Markdown
Contributor
  • dicom, dicom-json, dicom-pixeldata 0.9 -> 0.10
  • dicom-web (dev) 0.5 -> 0.6, required so the test build resolves a single dicom-object version
  • client_ae_title() -> peer_ae_title() (deprecated in dicom-ul 0.10);
  • trait imported anonymously to avoid the name clash with the crate's own Association trait

Copilot AI lite review requested due to automatic review settings September 14, 2026 17:17
- dicom, dicom-json, dicom-pixeldata 0.9 -> 0.10
- dicom-web (dev) 0.5 -> 0.6, required so the test build resolves a
  single dicom-object version
- client_ae_title() -> peer_ae_title() (deprecated in dicom-ul 0.10);
  trait imported anonymously to avoid the name clash with the crate's
  own Association trait

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The dependency bumps and associated API update appear complete and consistent, and remaining usages of the deprecated API were not found in the repository.

Pull request overview

This PR updates the project’s Rust DICOM stack to dicom-rs 0.10.x and applies the required small API adjustments so the DIMSE association code continues to compile and log correct peer information.

Changes:

  • Bumped dicom, dicom-json, and dicom-pixeldata from 0.9.0 to 0.10.0 (and dicom-web dev-dependency to 0.6.0).
  • Updated DIMSE server association logging to use peer_ae_title() (new dicom-ul API) and imported the upstream Association trait anonymously to avoid a name clash.
  • Recorded the dependency bump in the Unreleased changelog.
File summaries
File Description
src/backend/dimse/association/server.rs Updates upstream API usage (peer_ae_title) and trait import to stay compatible with dicom-ul 0.10.
CHANGELOG.md Notes the dicom-rs dependency update under Unreleased.
Cargo.toml Bumps DICOM-related crate versions (and dicom-web in dev-deps).
Cargo.lock Refreshes the resolved dependency graph for the upgraded crates.
Review details
  • Files reviewed: 3/4 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@nickamzol

Copy link
Copy Markdown
Member

Thanks!

@nickamzol
nickamzol merged commit 071487d into UMEssen:main Sep 17, 2026
2 checks passed
@holg

holg commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

You are welcome, just some small change, which came to my mind...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants