chore(deps): bump dicom-rs to 0.10 - #67
Merged
Merged
Conversation
holg
commented
Sep 14, 2026
Contributor
- dicom, dicom-json, dicom-pixeldata 0.9 -> 0.10
- dicom-web (dev) 0.5 -> 0.6, required so the test build resolves a single dicom-object version
- client_ae_title() -> peer_ae_title() (deprecated in dicom-ul 0.10);
- trait imported anonymously to avoid the name clash with the crate's own Association trait
- dicom, dicom-json, dicom-pixeldata 0.9 -> 0.10 - dicom-web (dev) 0.5 -> 0.6, required so the test build resolves a single dicom-object version - client_ae_title() -> peer_ae_title() (deprecated in dicom-ul 0.10); trait imported anonymously to avoid the name clash with the crate's own Association trait
holg
force-pushed
the
bump_dicom_0.10
branch
from
September 14, 2026 17:18
2a1588d to
63c31b2
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The dependency bumps and associated API update appear complete and consistent, and remaining usages of the deprecated API were not found in the repository.
Pull request overview
This PR updates the project’s Rust DICOM stack to dicom-rs 0.10.x and applies the required small API adjustments so the DIMSE association code continues to compile and log correct peer information.
Changes:
- Bumped
dicom,dicom-json, anddicom-pixeldatafrom0.9.0to0.10.0(anddicom-webdev-dependency to0.6.0). - Updated DIMSE server association logging to use
peer_ae_title()(newdicom-ulAPI) and imported the upstreamAssociationtrait anonymously to avoid a name clash. - Recorded the dependency bump in the Unreleased changelog.
File summaries
| File | Description |
|---|---|
src/backend/dimse/association/server.rs |
Updates upstream API usage (peer_ae_title) and trait import to stay compatible with dicom-ul 0.10. |
CHANGELOG.md |
Notes the dicom-rs dependency update under Unreleased. |
Cargo.toml |
Bumps DICOM-related crate versions (and dicom-web in dev-deps). |
Cargo.lock |
Refreshes the resolved dependency graph for the upgraded crates. |
Review details
- Files reviewed: 3/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
nickamzol
approved these changes
Sep 14, 2026
Member
|
Thanks! |
Contributor
Author
|
You are welcome, just some small change, which came to my mind... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.