Skip to content

Fix wrong transfer syntax recorded in file meta #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickamzol merged 1 commit into from
Sep 14, 2026
Merged

Fix wrong transfer syntax recorded in file meta #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
single request (e.g. for every instance of a STOW-RS request).
- Associations are no longer returned to the pool after a failed or partially completed message
exchange, as their state is unknown.
- Fix incorrect transfer syntax recorded in file meta when multiple presentation contexts were negotiated in STORE-SCP.

## Changed

Expand Down
8 changes: 6 additions & 2 deletions src/backend/dimse/cstore/storescp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,14 @@ impl StoreServiceClassProvider {

// Duration::MAX to indefinitely wait for incoming messages
while let Ok(message) = association.read_message(Duration::MAX).await {
let pctx_id = message
.presentation_context_id
.context("Missing presentation context id in received message")?;
let pctx = association
.presentation_contexts()
.first()
.context("No presentation context available")?;
.iter()
.find(|pctx| pctx.id == pctx_id)
.context("No negotiated presentation context matches the received message")?;
debug!(
"Used transfer syntax {} to read message",
pctx.transfer_syntax
Expand Down
Loading