refactor: move reporters into root source tree - #76
Conversation
Signed-off-by: Matt Rice <[email protected]> Co-authored-by: Reinis Martinsons <[email protected]>
Co-authored-by: Claude Fable 5 <[email protected]>
Co-authored-by: Chris Maree <[email protected]>
Co-authored-by: Pablo Maldonado <[email protected]>
…reporter # Conflicts: # .gitmodules
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
managed-oracle/src/reporters/README.md
Line 612 in b23773c
Use the surviving OpenZeppelin proxy source path
When manually verifying a freshly deployed proxy with this documented command, Forge cannot resolve the contract because this commit removes the nested pm-v2-oo-reporter OpenZeppelin dependency, while the referenced lib/openzeppelin-contracts-upgradeable/lib/openzeppelin-contracts/... path does not exist in the root project. The retained proxy source is under lib/openzeppelin-contracts/contracts/proxy/ERC1967/ERC1967Proxy.sol, so the verification example should use that path.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -422,8 +422,7 @@ contract UpgradeOOReporter is Script { | |||
|
|
|||
| if ( | |||
| !request.registered || requester != expectedRequester || request.requester != requester | |||
| || request.priceIdentifier != priceIdentifier | |||
…er-root-src # Conflicts: # README.md
0f476a3 to
4e90ad9
Compare
4 participants
Summary
src/reportersand Polymarket-specific code intosrc/reporters/integrationsThis is an alternative to #75 for keeping all contracts under the main source tree.
Compatibility
ManagedOptimisticOracleV2creation and runtime bytecode remain byte-for-byte unchanged, and production upgrade validation passesTest plan
forge build --sizesforge test --match-path "test/reporters/*"forge test --no-match-contract ".*Fork.*|ManagedOptimisticOracleV2UpgradeValidationTest"forge clean && forge test --match-contract ManagedOptimisticOracleV2UpgradeValidationTest -vvv