Skip to content

fix(artifact_handler): answer pending questions from ingested document content - #231

Open
Tharickv75 wants to merge 4 commits into
devfrom
fix/artifact-handler-ready-doc-content
Open

Tharickv75 wants to merge 4 commits into
devfrom
fix/artifact-handler-ready-doc-content

Conversation

@Tharickv75

Copy link
Copy Markdown
Contributor

Summary

  • After ingest finishes, load the ready document’s PageIndex chunks and answer the pending question from that text instead of keyword-searching with the user’s question.
  • Drop the “excerpts do not contain this information” prompt; if the document body is empty, say so without leaking retrieval internals.

Test plan

  • Send a WhatsApp image or PDF with a content question, wait for ready, and confirm the reply answers from the indexed text even when the question words are not in the document.
  • Confirm an empty indexed body gets a ready notice without the word “excerpts”.
  • Run tests/action/artifact_handler_interact_action/test_generate_ready_message.py.

Made with Cursor

@Tharickv75
Tharickv75 requested a review from eldonm as a code owner September 17, 2026 16:59
Tharickv75 and others added 2 commits September 17, 2026 13:03
@Tharickv75 Tharickv75 self-assigned this Sep 17, 2026
… and event tracking

- Introduced `_register_orchestrator_vocabulary` to declare vault tool results as trusted directive sources.
- Added `DOCUMENT_CONTENT_CONDITION` and `DOCUMENT_SELECTION_RULES` to improve document selection logic.
- Implemented event recording for saved documents and answered pending questions in `vault_events.py`.
- Created `ready_message.py` to manage ready-notice and pending-question responses.
- Updated `check_ingest_status` to utilize new event tracking and response generation.
- Added tests for document selection rules and event recording functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant