Skip to content

fix(egress): peel closer lines without dropping report fields - #224

Merged
eldonm merged 3 commits into
devfrom
fix/egress-peel-closer-lines
Sep 13, 2026
Merged

eldonm merged 3 commits into
devfrom
fix/egress-peel-closer-lines

Conversation

@Tharickv75

Copy link
Copy Markdown
Contributor

Summary

Updated _detect_peel_closers logic to peel trailing voice closer lines without stripping preceding text or report fields when sentences lack standard terminating punctuation.

Related issues

Type of change

  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change
  • Documentation
  • Chore / tooling / CI

Checklist

  • I read CONTRIBUTING.md and (for subsystem work) the local CLAUDE.md.
  • pre-commit run --all-files passes.
  • pytest tests/ passes; I added/updated tests for new behavior.
  • Bug fixes cite file:line in the description (jvagent/action/parameters.py:923-935).
  • Docs / CHANGELOG.md updated where relevant (entry under [Unreleased]).
  • No ADR was modified in place (changes of decision are written as a new, superseding ADR).

Notes for reviewers

  • Line-level peeling ensures fields like Location, Status, and Priority remain intact when glued to closers without sentence delimiters (.!?).

@Tharickv75 Tharickv75 self-assigned this Sep 11, 2026
@Tharickv75
Tharickv75 requested a review from eldonm as a code owner September 11, 2026 20:33
Eldon Marks and others added 2 commits September 13, 2026 17:56
Concurrent waiters hydrate distinct Python instances after serialized
create; object-identity checks flake under full-suite pre-push.

Co-authored-by: Cursor <[email protected]>
Narrow let-me-know invitation matching so report-field glue peels while
mid-line content like "let me know if the address…" stays intact.

Co-authored-by: Cursor <[email protected]>
@eldonm
eldonm merged commit 918d4a9 into dev Sep 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants