fix(interview): name the failed field in batch validation directives - #222
Merged
Merged
Conversation
Co-authored-by: Cursor <[email protected]>
Avoid prepending the field prompt onto say-crafted questions ending in '?'; keep same-line Then call guidance when rebuilding; note saved sibling fields when a Call directive is returned after a partial batch. Co-authored-by: Cursor <[email protected]>
Concurrent waiters hydrate distinct Python instances after serialized create; object-identity checks flake under full-suite pre-push. Co-authored-by: Cursor <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors batch failure directive generation to name the failed field clearly and eliminate redundant boilerplate messages when asking users for missing or invalid information.
"I still need a valid X"."I've saved the other details."prefix whenstored_any=Trueso users know their valid input was recorded."Ask:"prefixes from error messages and properly separates developer/model hints viaDIRECTIVE_GUIDANCE_MARKER.Call interview__skip_field...) without modification.Type of change
Checklist
CONTRIBUTING.mdand (for subsystem work) the localCLAUDE.md.pre-commit run --all-filespasses.pytest tests/passes; I added/updated tests for new behavior.file:linein the description.CHANGELOG.mdupdated where relevant (entry under[Unreleased]).Notes for reviewers
batch_failure_directivesignature indirective_compose.py:84to acceptstored_any.jvagent/action/interview/directive_compose.py:28-118andjvagent/action/interview/engine.py:777.