Repository navigation
Make directory cards and pages easier to scan - #12
Merged
Merged
Conversation
Shorter directory introduction and view descriptions, coloured schedule status badges, one time range per line with shorter twelve-hour times, larger field labels and button text, Call and Directions before the detail on resource pages, and a direct directory link in the project homepage introduction. Phone numbers show in North American format, addresses drop the country code, and dated changes no longer end in a double period.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: on a phone the first listing started below a long introduction, a view explanation, a location note and a schedule warning. Schedule status was a small line of text, today's hours were one long string ("9:00 a.m.–11:00 a.m., 12:00 p.m.–2:00 p.m., 3:00 p.m.–5:00 p.m."), field labels were about 13px, and Call and Directions on a resource page came after the full schedule and source list. The project homepage only linked to Kingston further down the page.
After: the directory introduction and view descriptions are shorter (still saying you do not need to prove a crisis). Schedule status is a coloured badge (green open, amber later today, neutral or caution otherwise). Today's hours show one range per line in shorter twelve-hour times ("9–11 a.m."), labels and button text are larger, and the current view's tag and an operator name that repeats the listing name are hidden. Resource pages show Call and Directions right after the summary. The project homepage has a "Find food in Kingston" button in its introduction.
Smaller fixes: phone numbers in resource details show as 613-546-0320 instead of +16135460320, full addresses drop the trailing country code, and dated schedule changes no longer end in "p.m..".
How: presentation and CSS only, plus Kingston's
presentation.introductiontext. No resource facts change. Twelve-hour locales drop ":00" viaIntl.DateTimeFormat.formatRange; 24-hour locales keep minutes. The "not live availability" note stays on the directory and the warning stays on resource pages; the per-card repeat of "Call before travelling" is removed. No service worker changes. Merging does not publish Kingston; a release is still a separate explicit step.Checks:
npm run check -- --allpassed typecheck, 77 unit/contract tests and all 28 Chromium browser tests locally (Firefox and WebKit are not installed in this environment and run in CI).