forked from pingdotgg/t3code
-
Notifications
You must be signed in to change notification settings - Fork 0
fix(server): a logged-out Claude CLI no longer reports as authenticated #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -126,6 +126,7 @@ it.layer(NodeServices.layer)("Claude capability probe SDK boundary", (it) => { | |
| email: "[email protected]", | ||
| subscriptionType: "pro", | ||
| tokenSource: "oauth", | ||
| apiKeySource: undefined, | ||
| apiProvider: undefined, | ||
| slashCommands: [ | ||
| { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
docs/fork/0015-a-logged-out-claude-install-reads-as-logged-out.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| # 0015: A logged-out Claude install reads as logged out | ||
|
|
||
| - PR: [TrogonStack/t3code#26](https://github.com/TrogonStack/t3code/pull/26) | ||
| - Status: active | ||
|
|
||
| ## What you can do now | ||
|
|
||
| - Tell at a glance whether a Claude instance can actually run. One whose CLI | ||
| holds no credentials reads as not authenticated in Settings and in the chat | ||
| banner, with the prompt to sign in that every other signed-out provider | ||
| already gets, instead of claiming to be authenticated and failing on the | ||
| first message you send it. | ||
| - Keep trusting the badge on instances that authenticate in the less common | ||
| ways. API-key installs, Bedrock and Vertex backends, and gateway or profile | ||
| setups still report as authenticated, none of which carry an account the way | ||
| a signed-in first-party install does. | ||
|
|
||
| ## Why | ||
|
|
||
| Settings answers one question: is this provider working. Claude answered it by | ||
| printing "Authenticated" for any instance whose CLI started at all, which is a | ||
| different question from whether that CLI has anything to authenticate with. | ||
|
|
||
| The gap only opens where several Claude accounts run side by side, each bound | ||
| to its own credential store, and that is exactly where the answer needs to be | ||
| right: instances that had never held a credential showed the same green badge | ||
| as the working one, and the only way to find out which was which was to start | ||
| a thread and watch it fail. A status that is correct in the ordinary case and | ||
| wrong in precisely the case you consulted it for is worse than no status, | ||
| because it spends the trust that makes the rest of the page worth reading. | ||
|
|
||
| ## Upstream considerations | ||
|
|
||
| Nothing here is fork-specific, so this belongs upstream as an ordinary bug | ||
| fix. Submit it, then delete this entry once it merges. It sits in the shared | ||
| Claude provider status check, so a sync must not drop it. The rebase burden is | ||
| small: the decision is one exported function over the capability probe's own | ||
| fields, and the only other change is a field the probe already had from the | ||
| SDK and was discarding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.