Repository navigation
Conversation
process_response checked the status code with "not in (200, 299)", a tuple membership test that only accepted 200 and 299. Use a 2xx range check so other successful responses with a body are not raised as errors. Behavior for 200, 204, 4xx and 5xx responses is unchanged.
transbankDev
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Este aporte lo realiza @jowyto en nombre de la organización Capitalizarme, que usa
transbank-sdk(Webpay Plus) en producción.Closes #163
Cambios
RequestService.process_responseevaluaba el éxito conresponse.status_code not in (200, 299), una pertenencia a tupla que solo aceptaba 200 y 299. Ahora usa el rango 2xx:not 200 <= response.status_code < 300.TransbankError.Net::HTTPSuccess), .NET (IsSuccessStatusCode) y Node (axios).Tests
Nuevo
tests/common/test_request_service.py, que pruebaprocess_responsecon respuestas simuladas:204error_message→TransbankErrorcon mensaje y códigodescription→TransbankErrorcon mensaje y códigoSin el fix, el test de 201 falla (
1 failed, 4 passed). Con el fix: