経路検索で複数種別のConnectedRoutesを利用 - #6529
Closed
TinyKitten wants to merge 14 commits into
Closed
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
変更内容
routeTypesで単一種別の経路が見つからない場合のみconnectedRoutesを問い合わせるlineGroupIdと経路内の駅列を保持し、初期候補および候補切替時にその駅列を直接使用する背景
現在の経路検索は
routeTypesの単一種別だけを前提としているため、途中で種別が変わる経路を構築できませんでした。単一種別で完結しない場合に限って ConnectedRoutes を使い、複数種別を一つの経路として扱います。影響
単一種別で到達できる既存経路の挙動は変わりません。単一種別が見つからなかった検索のみ追加のAPI呼び出しが発生します。
検証
lineGroupId、区間路線、区間種別を既存の列車種別モデルへ変換する単体テストを追加