Repository navigation
Revert "Reject short and torn uploads in ByteStream and FilesystemStore, and report QueryWriteStatus honestly (#2881)" - #2953
Merged
MarcusSorealheis merged 1 commit intoOct 16, 2026
Conversation
…re, and report QueryWriteStatus honestly (TraceMachina#2881)" This reverts commit 264b7eb.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Reverts #2881 for now. It needs a follow-up change before it can go into a release, so it shouldn't ship in the next release on its own. It will be relanded together with that change.
This restores the previous behavior: ByteStream accepts an early
finish_write,FilesystemStorecommits an upload regardless of theExactSizehint, and QueryWriteStatus reportscomplete = truewith the store's on-disk size.How was this verified?
A clean
git revertof 264b7eb on currentmain. No later commit touches the four files, and they match their pre-#2881 state exactly.Risk
Low. This brings back the gaps #2881 closed: short or torn uploads can be stored and reported as complete, and QueryWriteStatus can report the wrong committed size. That was the behavior before 2026-10-15.
AI assistance
I did a revert of the previous PR via an agent.