Repository navigation
Let font settings follow the account or stay on this device - #41
Closed
harikiran-lab wants to merge 2 commits into
Closed
harikiran-lab wants to merge 2 commits into
harikiran-lab wants to merge 2 commits into
Conversation
harikiran-lab
marked this pull request as ready for review
October 21, 2026 16:54
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Font family and text size in the proposed typography controls are device-only, so opening the same account in another browser or incognito restores the original typography.
Adds Appearance → Typography → Font settings with Across devices (default) and This device only. The choice controls both font family and text size and stays local to each account/device. Opting back into account sync shares the current selection. Existing local selections seed only missing account values; fresh-browser defaults never replace saved account typography. Direct saves, incoming settings, native SQLite sync, and offline retries honor the selected scope. Includes regression tests and an Unreleased changelog entry.
Depends on #38. Upstream dev does not yet contain the font controls, so this draft includes #38's typography commit rebased onto current dev, followed by the scope change. The additional sync work can be reviewed in the second commit. Once #38 lands, this can be rebased to show only the sync changes. No workflow changes or unrelated fork features are included.
Validation on this upstream branch: all 19 focused font/typography/size tests, i18n check, and production build pass. The equivalent sync implementation also passed the full Linux test suite in the fork's CI. Native integration coverage exercises opting out with pending settings and opting back in with the current local selection.