Repository navigation
Run reminder sweep tests on a fixed clock - #1
Merged
Merged
Conversation
The overlap and stale-backlog tests swept on the real clock, so the follow-up planned by an earlier test for 9 Nov 2026 became due and was emailed too. Pass a fixed clock to sweep() in both tests so only the reminder under test is due, whatever today's date is. Assertions are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The overlap test ("sends each due reminder once, even when sweeps overlap") started failing on 9 Nov 2026. The first test plans a follow-up from a fixed date (applied 2 Nov, due 9 Nov 09:00), and once that date passed, the real-clock sweep in the overlap test emailed it as well (2 emails instead of 1). The stale-backlog test had the same problem.
sweeper.sweep(now), so only the reminder under test is due, whatever today's date is.sentAt: nullin the claim's where clause) still fails the overlap test with 2 emails.