Conversation
memehri
reviewed
Sep 8, 2026
| * @param timeToLive Item time to live | ||
| * @param timeUnit Time unit for time to live | ||
| */ | ||
| boolean addItemToHashIfAbsent(String cacheName, Object key, Object value, Long timeToLive, TimeUnit timeUnit); |
Collaborator
There was a problem hiding this comment.
I think cacheName should not be part of this method's input.
If this is a hash-specific operation, the API should be something like:
addItemToHashIfAbsent(Object key, Object value, Long timeToLive, TimeUnit timeUnit)
The cache name should be resolved by the implementation/context rather than being passed by the caller.
Author
There was a problem hiding this comment.
To keep it uniform with other methods functionalities in TedissonLocalCacheManagerImpl (using cache methods and considering key as the cache name), I renamed the method name instead.
memehri
reviewed
Sep 13, 2026
| * @param timeToLive Item time to live | ||
| * @param timeUnit Time unit for time to live | ||
| */ | ||
| boolean addItemToCashIfAbsent(String cacheName, Object key, Object value, Long timeToLive, TimeUnit timeUnit); |
Collaborator
There was a problem hiding this comment.
Please change Cash to Cache in the method name:
addItemToCashIfAbsent
→
addItemToCacheIfAbsent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.