Repository navigation
test(mla): #110-B Review-Minors aus dem Follow-up-Pool (#110) - #114
Merged
Merged
Conversation
…-Asserts, FLAGGED_TLDS - test/fixtures/README.md: Paritäts-Tabelle auf linux_system.dart:26/:13-15/:57 nachgezogen (Drift aus dem #94-Task-5-Fix), Bug-Notiz-Ref :11→:13-15, TLD-Allowlist→TLD-Flag-Liste umbenannt und die stale .ai-Raster-Aussage korrigiert (.ai ist seit 643da93 in der Liste; Beispiel jetzt .store). - parsePsOutput count≤0-Kante als Test gepinnt (Verhalten: alle Einträge, kein Produktions-Caller); Mutationsbeleg: count<=0→empty schlägt fehl. - Spawn-Test Fall 6: voller Fehler-Vertrag gepinnt (output isEmpty + error enthält die OS-Lookup-Meldung, toolchain-gemessen 'No such file or directory' statt isNotEmpty-Blob). - Spawn-Test 8: exakte Präfixkette statt startsWith("PATH=/") — der Kind-Prozess sieht exakt den Parent-PATH. - ALLOWED_TLDS→FLAGGED_TLDS (Misnomer, #110-B): Liste ist die Flag-Liste des Detektionsmusters, keine Allowlist. Gates (night/pool-b @ 506eb88): check-versions ok; dart format 123/0 (Flutter-Dart 3.13.4); flutter analyze 0; la_core format 24/0 + analyze 0 + test +62; flutter test +208; python 53/53. Snap-dart format-Drift-Befund (111 changed) war Binärpfad-Artefakt, dokumentiert im Handoff.
- F1 (Reviewer A): Parser-Doccomment um die count≤0-Kante ergänzt —
'A count of 0 or less disables the limit: every valid entry is
returned.' Der Test-Kommentar-Bezug ('documented in the parser's doc
comment') ist damit wahr; vorher dokumentierte der Doc nur positive
counts und widersprach der Kante milde.
- F2 (Reviewer A): VERIFY.md:354 stale .ai-Aussage in Vergangenheitsform
korrigiert ('seit 643da93 in der Flag-Liste') — Gegenwart-Form war seit
Task 3 des Follow-up-PRs falsch.
- Handoff #110-B-Sektion in VERIFY.md (Status, Umsetzung je Checkbox,
Reviewer-Verdicts A NEEDS_FIXES→fixed / B READY_FOR_PR, Gatetabelle,
Rückfallplan, Grenzen).
Verdict gesamt: READY_FOR_PR (A Minors gefixt, B ohne Blocker).
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The exact PATH test uses unquoted shell expansion, making it fail for valid PATH values containing whitespace or glob characters.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Implements Issue #110 pool item B with parser/runner tests and documentation corrections.
Changes:
- Pins
parsePsOutputbehavior for non-positive counts. - Strengthens process-runner assertions.
- Renames the TLD detection constant and updates documentation.
| File | Description |
|---|---|
test/process_command_runner_test.dart |
Strengthens process failure and PATH assertions. |
test/fixtures/README.md |
Corrects references and TLD terminology. |
packages/la_core/test/parsers_test.dart |
Tests non-positive count behavior. |
packages/la_core/lib/src/parsers/process.dart |
Documents count semantics. |
docs/mla-next/VERIFY.md |
Records implementation and verification details. |
additional/python/tests/test_fixture_leak_check.py |
Renames the TLD detection constant. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| expect(result.success, isTrue); | ||
| expect(result.output.trim(), startsWith("PATH=/")); | ||
| expect(result.output.trim(), "PATH=$parentPath"); |
…110-B) aufgelöst Co-Authored-By: Claude Code <[email protected]>
7 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basis-SHA:
506eb88(main) · Branch:night/pool-b· 2 Commits · 6 Dateien, +82/−12Pool-Position B aus Issue #110 (Review-Minors aus dem Task-6-Review der MLA-Next-Kette). Umgesetzt im Nachtlauf 2026-09-30 (Queue-Automation, Worktree-isoliert), hier veröffentlicht. Reine Test-/Doku-/Naming-Fixes an der la_core-Parser- und Runner-Grenze.
Was drin ist
linux_system.dart:22→:26, :13-14→:13-15, :53→:57), Bug-Notiz-Ref :11→:13-15; zusätzlich „TLD-Allowlist"→„TLD-Flag-Liste" und die stale.ai-Raster-Aussage korrigiert (.aiist seit643da93geflaggt; Beispiel jetzt.store).count 0 or negative yields every entry, not an empty listpinnt count=0 und −1 → alle Einträge. Mutationsbeleg gefahren (Mutantecount<=0 → emptyfailt).isNotEmpty:output isEmpty(Runner hardcodet""auf dem ProcessException-Pfad) +error contains "No such file or directory".PATH=$parentPathstattstartsWith("PATH=/").ALLOWED_TLDS→FLAGGED_TLDS— Rename (Definition + einzige Usage), Kommentar dokumentiert den Misnomer; README-Prosa an 2 Stellen mitgezogen.Gates — tatsächlich ausgeführt (2026-09-30, auf
64ba632)bash tool/check-versions.shversion 0.8.0 is consistentdart format --output=none --set-exit-if-changed lib testFormatted 123 files (0 changed)flutter analyzeNo issues found!dart format/dart analyze/dart test24 files (0 changed)·No issues found!·+62: All tests passed!flutter test+208: All tests passed!additional/pythonunittest discoverRan 53 tests/OKKeine roten Gates. Nicht ausgeführt:
build-deb.sh(kein Packaging-Bezug, CI baut im PR), manuelle Gate-0-Checks (Basti).Review
Dual-Review (2 parallele Subagenten) auf dem Branch-Diff: A (Korrektheit) NEEDS_FIXES — 2 Minors (Parser-Doccomment dokumentierte die count-Kante nicht; VERIFY.md:354 stale
.ai-Gegenwartsform) → gefixt in3b1aaaf. B (Vollständigkeit/Spec) READY_FOR_PR — alle 5 Checkboxen erfüllt, Scope exakt 4 Dateien, Gates eigenständig grün. Re-Review A: beide Minors gefixt ⇒ gesamt READY_FOR_PR.Bewusst offen
README:137
:19-Ref (vorbestehend, außerhalb des B-Buchstabens) — als Minor notiert.Rückfallplan
git revert 64ba632 3b1aaafgenügt — 2 Test-Dateien, 1 README, 1 Python-Test, 1 Parser-Doccomment, 1 VERIFY-Zeile. Kein Produktionscode außer dem Doccomment, keine Unit, kein Packaging, polkit-Trinität unberührt.Kein Merge ohne gesonderte Freigabe.
🤖 Generated with Claude Code