Repository navigation
Group related addon folders into one addon entry - #5
Merged
Topher121 merged 3 commits intoOct 27, 2026
Merged
Conversation
Addons with multiple folders could appear as separate entries because Group metadata was ignored and module names without separators missed the name-stem fallback. - Read TOC Group metadata and group standalone modules when it names an installed required dependency, combining related folders into one entry. - Preserve catalogue, project and recorded installation ownership, including managed packages with folder: keys. - Share the ownership check and flatten the parent walk while retaining its ownership boundaries and four-step limit. - Add regression coverage for addon suites, unrelated addons, missing parents, optional dependencies and independently owned packages.
- Group direct required dependencies when the catalogue opts in, retaining existing module membership and separate package ownership. - Reuse existing installation keys and recognise catalogue membership by ID in Browse and Starter packs. - Reject conflicting archive targets before replacing installed folders. - Document the opt-in and add grouping, ownership and bundle-version regression tests.
Owner
|
Thanks, this is a big one. Could the folder protection only apply to folders that actually exist on disk? Old install records aren’t cleaned up when people delete folders by hand, so a stale record could block a valid install |
Apply ownership protection only to folders present on disk. After successful installation, transfer folder claims to the new owner, preserving unrelated folders and removing emptied records. Add regression coverage for stale claims, existing-folder protection, ownership cleanup, and subsequent updates.
Contributor
Author
|
Well, its looks bigger than it is - most of it are tests to establish a baseline behavior. |
Owner
|
Thanks! Merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addons split across directories can appear as multiple entries. Group standalone modules using TOC
Groupmetadata and required parent dependencies, and add a catalogue opt-in for bundled required dependencies.Catalogue follow-up: Enable
"group_required_dependencies": truefor Questie incatalog/forever.json, retainingfolders: ["Questie"], so QuestieDB joins Questie when the main addon is present.