Repository navigation
Detect WoW installations in custom locations - #4
Merged
Topher121 merged 2 commits intoOct 27, 2026
Merged
Conversation
Installations outside the predefined directory layouts were missed. Use local Battle.net metadata and configuration to discover them. Return executable-validated installations with their WoW type and ordinary filesystem paths. Compare canonical paths to avoid duplicates.
Owner
|
Thanks for this. One thing: could it accept any Wow*.exe rather than the fixed list? Nobody knows what the live client’s exe will be called on 4 Nov, and I don’t want auto-detection to miss it on launch day. |
Replace the fixed executable list with a case-insensitive Wow*.exe match so new client names are detected without updating the list.
Contributor
Author
|
Sure - im pretty sure it will be 'Wow.exe' because you can already download the forever client for the upcoming naming reserving, but better save than sorry^^ |
Owner
|
Thank you! Merged |
Topher121
added a commit
that referenced
this pull request
Oct 30, 2026
Detect WoW installations in custom locations
Topher121
pushed a commit
that referenced
this pull request
Nov 3, 2026
…tection Detect WoW installations in custom locations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WoW installations outside the predefined directory layouts were missed. Discover them using Battle.net’s local installation database and configured install location, while retaining the existing fallback paths.
Validation:
git diff --check main...HEADpassed.cargo testpassed: 23 tests, 0 failures.